Change in vdsm[master]: gluster: proper check in gfapi.py to avoid segfault in libgfapi

dnarayan at redhat.com dnarayan at redhat.com
Wed Nov 19 05:54:51 UTC 2014


Darshan N has posted comments on this change.

Change subject: gluster: proper check in gfapi.py to avoid segfault in libgfapi
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35256/1/vdsm/gluster/gfapi.py
File vdsm/gluster/gfapi.py:

Line 51: def glfsInit(volumeId, host, port, protocol):
Line 52:     fs = _glfs_new(volumeId)
Line 53:     if fs is None:
Line 54:         raise ge.GlfsInitException(
Line 55:             rc=7,
> "7" was a silly ad-hoc invention by me. Can you extract a more meaningful d
Done
Line 56:             err=['glfs_new(%s) failed' % volumeId]
Line 57:         )
Line 58: 
Line 59:     rc = _glfs_set_volfile_server(fs,


-- 
To view, visit http://gerrit.ovirt.org/35256
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie32cdc723a78a30a4efc0c2e75e1b308fc756bf3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list