Change in vdsm[master]: refactor StaticSourceRoute for better testability

danken at redhat.com danken at redhat.com
Tue Nov 18 13:04:22 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: refactor StaticSourceRoute for better testability
......................................................................


refactor StaticSourceRoute for better testability

changed the way this object is built such that most of the relevant
information is known at object creation time. This allows better
testability as the routing rules and ip rules generators can be
always accessed directly by tests.

Change-Id: If81c71b83670ee0c721dcce449e48ccc21e3bbec
Signed-off-by: ibarkan <ibarkan at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/34067
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
M vdsm/network/configurators/__init__.py
M vdsm/network/sourceroute.py
M vdsm/network/sourceroutethread.py
4 files changed, 71 insertions(+), 123 deletions(-)

Approvals:
  Ido Barkan: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34067
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If81c71b83670ee0c721dcce449e48ccc21e3bbec
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list