Change in vdsm[master]: sampling: extract SampleWindow class

danken at redhat.com danken at redhat.com
Tue Nov 18 11:54:58 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: sampling: extract SampleWindow class
......................................................................


Patch Set 6: Code-Review+2

(2 comments)

http://gerrit.ovirt.org/#/c/33783/6/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 306: _MINIMUM_SAMPLES = 1
Line 307: 
Line 308: 
Line 309: class SampleWindow(object):
Line 310:     """Keep sliding window of samples."""
keep *a*
Line 311: 
Line 312:     def __init__(self, size, timefn=time.time):
Line 313:         if size < _MINIMUM_SAMPLES:
Line 314:             raise ValueError("window size must be not less than %i" %


Line 308: 
Line 309: class SampleWindow(object):
Line 310:     """Keep sliding window of samples."""
Line 311: 
Line 312:     def __init__(self, size, timefn=time.time):
in another patch, avoid glitches due to TZ changes with

 timefn=lamda: os.times()[-1]
Line 313:         if size < _MINIMUM_SAMPLES:
Line 314:             raise ValueError("window size must be not less than %i" %
Line 315:                              _MINIMUM_SAMPLES)
Line 316: 


-- 
To view, visit http://gerrit.ovirt.org/33783
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48fe9e7f8ed3f5ec677d8f91a82cb70d0bdbb2e7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list