Change in vdsm[master]: protocoldetector: Fix polling timeout

danken at redhat.com danken at redhat.com
Mon Nov 17 12:01:13 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: protocoldetector: Fix polling timeout
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/35212/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: protocoldetector: Fix polling timeout
Line 8: 
Line 9: The event loop was calculating timeout in seconds, but poll timeout
Line 10: should be milliseconds. This caused poll to wait up to 30 milliseconds
Oh dear.

https://docs.python.org/2/library/select.html#select.epoll.poll is in seconds, but https://docs.python.org/2/library/select.html#select.poll.poll is in milliseconds. Designed to Confuse.
Line 11: instead of 30 seconds where there are no events to handle.
Line 12: 
Line 13: Profiling a system running one vm for 5 mintues show _process_events is
Line 14: dominating the profile, taking 55% of cpu time:


-- 
To view, visit http://gerrit.ovirt.org/35212
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If676b543bff30d08067d2cff3e0639c7e415f61f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list