Change in vdsm[master]: Provide device details using python-blivet module

tjeyasin at redhat.com tjeyasin at redhat.com
Mon Nov 17 07:39:34 UTC 2014


Timothy Asir has posted comments on this change.

Change subject: Provide device details using python-blivet module
......................................................................


Patch Set 3:

(6 comments)

http://gerrit.ovirt.org/#/c/35028/3/vdsm/gluster/storageconf.py
File vdsm/gluster/storageconf.py:

Line 23: 
Line 24: _bb = None
Line 25: 
Line 26: 
Line 27: def getBlivet():
> Make it private function
Done
Line 28:     global _bb
Line 29:     if _bb:
Line 30:         return _bb
Line 31: 


Line 52:         if device.parents:
Line 53:             info['container'] = device.parents[0].path
Line 54:             info['parent'] = device.parents[0].name
Line 55:         if hasattr(device.format, 'mountpoint'):
Line 56:             info['contentType'] = _getContentType(device.format.mountpoint)
> remove contentType
Done
Line 57:             info['mount'] = device.format.mountpoint
Line 58:             info['fileSystem'] = device.format.type
Line 59:         info['model'] = device.model
Line 60:         info['type'] = device.type


Line 53:             info['container'] = device.parents[0].path
Line 54:             info['parent'] = device.parents[0].name
Line 55:         if hasattr(device.format, 'mountpoint'):
Line 56:             info['contentType'] = _getContentType(device.format.mountpoint)
Line 57:             info['mount'] = device.format.mountpoint
> do we need mount flags?
I will add it
Line 58:             info['fileSystem'] = device.format.type
Line 59:         info['model'] = device.model
Line 60:         info['type'] = device.type
Line 61:         if device.uuid:


Line 54:             info['parent'] = device.parents[0].name
Line 55:         if hasattr(device.format, 'mountpoint'):
Line 56:             info['contentType'] = _getContentType(device.format.mountpoint)
Line 57:             info['mount'] = device.format.mountpoint
Line 58:             info['fileSystem'] = device.format.type
> is it possible to get filesystem flags like inode size etc?
currently blivet does not provide inode details
Line 59:         info['model'] = device.model
Line 60:         info['type'] = device.type
Line 61:         if device.uuid:
Line 62:             info['uuid'] = device.uuid


Line 58:             info['fileSystem'] = device.format.type
Line 59:         info['model'] = device.model
Line 60:         info['type'] = device.type
Line 61:         if device.uuid:
Line 62:             info['uuid'] = device.uuid
> 1. Add device uuid as 'devuuid'
Done
Line 63:         info['formattable'] = device.format.formattable
Line 64:         info['resizable'] = device.format.resizable
Line 65:         info['size'] = device.size
Line 66:         deviceInfo.append(info)


Line 59:         info['model'] = device.model
Line 60:         info['type'] = device.type
Line 61:         if device.uuid:
Line 62:             info['uuid'] = device.uuid
Line 63:         info['formattable'] = device.format.formattable
> what is formattable?
Its just like, whether this device can be reformated or not. I will remove this info
Line 64:         info['resizable'] = device.format.resizable
Line 65:         info['size'] = device.size
Line 66:         deviceInfo.append(info)


-- 
To view, visit http://gerrit.ovirt.org/35028
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85f520c6f476731cb5982d8256cb701387be87cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nishanth Thomas <nishusemail at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list