Change in vdsm[master]: image: use qemu-img convert to copy internal volumes

fromani at redhat.com fromani at redhat.com
Mon Nov 17 07:39:27 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 3:

(1 comment)

Nice one, added only comment(s) for possible readability improvements

http://gerrit.ovirt.org/#/c/33355/3/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 432:                                                    volUUID=srcVol.volUUID)
Line 433:                     srcFormat = volume.fmt2str(srcVol.getFormat())
Line 434:                     dstFormat = volume.fmt2str(dstVol.getFormat())
Line 435: 
Line 436:                     pntVol = dstVol.getParentVolume()
maybe 'parentVolume' is more readable?
Line 437: 
Line 438:                     if pntVol is not None:
Line 439:                         backing = volume.getBackingVolumePath(
Line 440:                             imgUUID, pntVol.volUUID)


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list