Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

ybronhei at redhat.com ybronhei at redhat.com
Thu Nov 13 07:24:45 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/27025/2/Makefile.am
File Makefile.am:

Line 90: 	      echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \
Line 91: 	  done; \
Line 92: 	fi;
Line 93: 
Line 94: EXT_FILES = \
> Why are these defined?
damn leftover.. sorry
Line 95: 	vdsm_reg/vdsm-reg-setup.in \
Line 96: 	$(NULL)
Line 97: 
Line 98: SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines \


-- 
To view, visit http://gerrit.ovirt.org/27025
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6be99965f3249374c99c1d4ab71145d571c13921
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list