Change in vdsm[master]: Fix ballooning behaviour of freshly received VM
danken at redhat.com
danken at redhat.com
Thu Nov 13 05:47:46 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: Fix ballooning behaviour of freshly received VM
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/34887/2/tests/vmTests.py
File tests/vmTests.py:
Line 1505: testvm._dom = fake.Domain(
Line 1506: virtError=libvirt.VIR_ERR_NO_DOMAIN)
Line 1507: mock_stats_thread = vm.VmStatsThread(testvm)
Line 1508: res = mock_stats_thread.get()
Line 1509: self.assertIn('balloonInfo', res)
> Because it does not belong here. The test is not related to ballooning at a
Ok.
Line 1510:
Line 1511: def testMultipleGraphicDeviceStats(self):
Line 1512: devices = [{'type': 'graphics', 'device': 'spice', 'port': '-1'},
Line 1513: {'type': 'graphics', 'device': 'vnc', 'port': '-1'}]
--
To view, visit http://gerrit.ovirt.org/34887
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If44c8e9d65b7221b2dec5fdd1f2d7d4343f7aeaa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list