Change in vdsm[master]: Memory Hotplug
vdelima at redhat.com
vdelima at redhat.com
Wed Nov 12 23:26:32 UTC 2014
Vitor de Lima has posted comments on this change.
Change subject: Memory Hotplug
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/35080/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 7777: # Set the amount of memory for a VM
Line 7778: #
Line 7779: # @vmID: The UUID of the VM
Line 7780: #
Line 7781: # @amountOfMemory: The new amount of memory
> bytes/MB/GB?
It will depend on how libvirt will implement this.
Line 7782: #
Line 7783: # Returns:
Line 7784: # The VM definition, as updated
Line 7785: #
http://gerrit.ovirt.org/#/c/35080/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3072: return {'status': doneCode, 'vmList': self.status()}
Line 3073:
Line 3074: def setAmountOfMemory(self, amountOfMemory):
Line 3075:
Line 3076: if self.isMigrating():
> how about when VM is Paused?
This is concerning because this is the only check in the CPU hotplug too.
Line 3077: return errCode['migInProgress']
Line 3078:
Line 3079: self.log.debug("Setting amount of memory to : %s", amountOfMemory)
Line 3080:
--
To view, visit http://gerrit.ovirt.org/35080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82bb7d1f7eaaca67b0ceebb4e782ea36541c81c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list