Change in vdsm[master]: multipath: add specific fail entry for emc-vnx

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 12 16:48:35 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: multipath: add specific fail entry for emc-vnx
......................................................................


Patch Set 1: Code-Review-1

When I tested this, overriding a devices override the entire device configuration, not only the properties you define in the devices section.

If the builtin configuration was:

device {
    a 1
    b 2
}

And you override a device in the devices section:

devices {
    device {
        a 1
    }
}

Then property "b" would not use the builtin value, but the defualt value.

If it worked as we expected (overiding only specified properties), we could add this rule to match all devices:

device {
    vendor "*"
    product "*"
    no_path_retry fail
}

So this patch should add the properties from the builtin device:

    device {                                                                                                                                                                    
        # Builtin settings
        vendor "DGC"
        product ".*"
        product_blacklist "LUNZ"
        path_grouping_policy "group_by_prio"
        path_checker "emc_clariion"
        hardware_handler "1 emc"
        prio "emc"
        failback "immediate"
        rr_weight "uniform"
        # Overrides
        features "0"
        no_path_retry fail
    }

-- 
To view, visit http://gerrit.ovirt.org/35072
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf5f4c89eac1273bf3a8e1afa300fec7b5b68eae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list