Change in vdsm[master]: adding tx/rx statistic to getInterfacesStats
danken at redhat.com
danken at redhat.com
Wed Nov 12 16:41:19 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: adding tx/rx statistic to getInterfacesStats
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35061/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 654: 'txErrors': str(iface.txErrors),
Line 655: 'state': iface.operstate,
Line 656: 'rxRate': '%.1f' % rxRate,
Line 657: 'txRate': '%.1f' % txRate,
Line 658: 'rxTotal': str(iface.rx),
> How big both values are? Do we really need to convert to string?
They are 64bit, I believe, which means that str() is required for xmlrpc.
Line 659: 'txTotal': str(iface.tx),
Line 660: }
Line 661: rxDropped += hs1.interfaces[ifid].rxDropped
Line 662: txDropped += hs1.interfaces[ifid].txDropped
--
To view, visit http://gerrit.ovirt.org/35061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I314a04570dec56677168e0fdb4a7824d299dbd65
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amir Shladovsky <a.shlado at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list