Change in vdsm[master]: utils: faster albeit less general deepcopy

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 12 16:20:44 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: utils: faster albeit less general deepcopy
......................................................................


Patch Set 5:

Can you add a test using typical vm conf dict, measuring the time to utils.pickecopy vs copy.deepcopy?

I would do the timing using timeit module, using 1000 iterations for each copy.

If copy.deepcopy is faster the test should fail.

-- 
To view, visit http://gerrit.ovirt.org/34989
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I936a977e9f41863bdff18b9343d252ab0996d554
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list