Change in vdsm[master]: utils: faster albeit less general deepcopy

fromani at redhat.com fromani at redhat.com
Wed Nov 12 12:40:06 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: utils: faster albeit less general deepcopy
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/34989/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 1180: 
Line 1181:     To be faster, this function expects the
Line 1182:     argument to be pickle-able.
Line 1183: 
Line 1184:     It is recommended to use this function only
> It is not about recommendation, but more "this can handle only".
Good point. will do.
Line 1185:     with primitive python types, including any
Line 1186:     arrangemente of them
Line 1187:     (e.g. dict() inside list() inside dict()).
Line 1188:     """


-- 
To view, visit http://gerrit.ovirt.org/34989
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I936a977e9f41863bdff18b9343d252ab0996d554
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list