Change in vdsm[master]: netlink: replace old ipwrapper event monitor

asegurap at redhat.com asegurap at redhat.com
Tue Nov 11 18:05:47 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: netlink: replace old ipwrapper event monitor
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/34929/3/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 170:     try:
Line 171:         state = operstate(device).lower()
Line 172:         if state == 'unknown':
Line 173:             for event in monitor:
Line 174:                 if event.device == device and event.state != 'unknown':
if I'm not mistaken now the monitor is raising just dictionaries, but you are keeping an interface here like if we still returned 'event' objects like from the ipwrapper monitor.
Line 175:                     break
Line 176:     finally:
Line 177:         mon.stop()
Line 178: 


-- 
To view, visit http://gerrit.ovirt.org/34929
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7a9765e59a8392fff9b3fd556133159aeb60b1c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list