Change in vdsm[ovirt-3.5]: Extract the DOM to Drive name, alias and path logic to reusa...

msivak at redhat.com msivak at redhat.com
Tue Nov 11 15:30:04 UTC 2014


Martin Sivák has posted comments on this change.

Change subject: Extract the DOM to Drive name, alias and path logic to reusable method
......................................................................


Patch Set 4: Verified+1

I verified this topic branch as a whole.

- I tested migration
- Setting and updating the ioTune values using vdscli Python API
- Starting a VM with ioTune profile from the engine

and checked that the values are reported using the API and visible in virsh dumpxml.

I also ran CI tests using this whole topic branch and all went well apart from CI tasks that were broken on the CI side. (Some tasks were fixed and then restarted as you can see in the results)

http://jenkins-ci.eng.lab.tlv.redhat.com/view/RHEV/view/DEVLOPERS%20TOOLS/job/rhev_3.5_developer/222/

-- 
To view, visit http://gerrit.ovirt.org/30066
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7389dd8960c9c6245148d9191b2bea5a7e9e4a46
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list