Change in vdsm[ovirt-3.5]: Improve the _validateIoTuneParams so the params are passed a...

msivak at redhat.com msivak at redhat.com
Tue Nov 11 13:45:17 UTC 2014


Martin Sivák has posted comments on this change.

Change subject: Improve the _validateIoTuneParams so the params are passed as argument
......................................................................


Patch Set 4: Verified+1

I verified this topic branch as a whole.

- I tested migration there and back again
- Setting and updating the ioTune values using vdscli Python API
- Starting a VM with ioTune profile from the engine

and checked that the values are reported using the API and visible in virsh dumpxml.

I also ran CI tests using this whole topic branch and all went well apart from CI tasks that were broken on the CI side. (Some tasks were fixed and then restarted as you can see in the results)

http://jenkins-ci.eng.lab.tlv.redhat.com/view/RHEV/view/DEVLOPERS%20TOOLS/job/rhev_3.5_developer/222/

-- 
To view, visit http://gerrit.ovirt.org/30069
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e8bd5a25320f45501b35bb0c9cae507200eb8b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list