Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd

Federico Simoncelli fsimonce at redhat.com
Tue Nov 11 09:59:17 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: utils: move nice ionice sid and sudo out of execCmd
......................................................................


Patch Set 2:

No need to downvote on the promise of future patches. We can discuss the names and the signature of the functions (I have no problem in using "sudo" instead of "sudo_cmd").

Keeping this patch is easier for me so I don't get blocked on my part and it's easier for Dima that can use it as a starting point for the rest of the cleanup as well.

-- 
To view, visit http://gerrit.ovirt.org/33691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list