Change in vdsm[master]: blockVolume: remove inexplicable fixme comment

danken at redhat.com danken at redhat.com
Tue Nov 11 09:44:28 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: blockVolume: remove inexplicable fixme comment
......................................................................


blockVolume: remove inexplicable fixme comment

There's no apparent reason for this fixme. Since the line is raising an
exception the "fix me" string appears in the tracebacks making our code
appear sloppy.

I searched for other inexplicable fixmes but it seems that this was the
only one.

Change-Id: I39c5a2034fdc7e5300259a2c5a25b0aed7f679b6
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33949
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/blockVolume.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Federico Simoncelli: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33949
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39c5a2034fdc7e5300259a2c5a25b0aed7f679b6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list