Change in vdsm[master]: vdsm-reg: Fix closed log file descriptors

dkuznets at redhat.com dkuznets at redhat.com
Sun Nov 9 20:19:45 UTC 2014


Dima Kuznetsov has uploaded a new change for review.

Change subject: vdsm-reg: Fix closed log file descriptors
......................................................................

vdsm-reg: Fix closed log file descriptors

When calling createDaemon(), all file descriptors are closed, including
the file descriptors held by log handlers. This patch moves logging
configuration below the daemonization to make sure the file descriptors
stay open.

Change-Id: Ida11e61aea18fbb2990176889423d2c4b6292a09
Signed-off-by: Dima Kuznetsov <dkuznets at redhat.com>
---
M vdsm_reg/vdsm-reg-setup.in
1 file changed, 9 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/34981/1

diff --git a/vdsm_reg/vdsm-reg-setup.in b/vdsm_reg/vdsm-reg-setup.in
index 5a4cd1b..84f137d 100644
--- a/vdsm_reg/vdsm-reg-setup.in
+++ b/vdsm_reg/vdsm-reg-setup.in
@@ -371,19 +371,22 @@
     pidfile = config.get('vars', 'pidfile')
     sleepTime = float(config.get('vars', 'reg_req_interval'))
 
-    loggerConf = config.get('vars', 'logger_conf')
-    logging.config.fileConfig(loggerConf, disable_existing_loggers=False)
-    log = logging.getLogger('')
-
-    _createUpgradeDir(os.path.dirname(config.get('vars', 'upgrade_iso_file')))
-
     try:
         if daemonize:
             createDaemon.createDaemon()
+
+        loggerConf = config.get('vars', 'logger_conf')
+        logging.config.fileConfig(loggerConf, disable_existing_loggers=False)
+        log = logging.getLogger('')
+
+        if daemonize:
             log = logging.getLogger('vdsRegistrator')
         else:
             log.handlers.append(logging.StreamHandler())
 
+        _createUpgradeDir(
+            os.path.dirname(config.get('vars', 'upgrade_iso_file')))
+
         log.info("After daemonize - My pid is %d", os.getpid())
         with open(pidfile, 'w') as f:
             f.write(str(os.getpid()) + "\n")


-- 
To view, visit http://gerrit.ovirt.org/34981
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida11e61aea18fbb2990176889423d2c4b6292a09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>


More information about the vdsm-patches mailing list