Change in vdsm[master]: tool: change configure verb logic.
mtayer at redhat.com
mtayer at redhat.com
Sun Nov 9 15:43:17 UTC 2014
mooli tayer has posted comments on this change.
Change subject: tool: change configure verb logic.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/34100/2/tests/toolTests.py
File tests/toolTests.py:
Line 252: pass
Line 253: c, args = Thing(), Thing()
Line 254: setattr(c, 'name', lambda: "Mock")
Line 255:
Line 256: for (isconfigured, isvalid, force, expected) in (
> Does this pass pep8?
yes:
$ git log --oneline -1
0ff7f1d tool: change configure verb logic.
$ pep8 --filename '*.py,*.py.in' .
./vdsm_reg/config.py:32:80: E501 line too long (81 > 79 characters)
./vdsm/sos/vdsm.py:130:80: E501 line too long (95 > 79 characters)
Line 257: (YES, True, True, False),
Line 258: (YES, True, False, False),
Line 259: (YES, False, True, InvalidConfig),
Line 260: (YES, False, False, InvalidConfig),
--
To view, visit http://gerrit.ovirt.org/34100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I166fbae855ebff93ef84270f11b74f32fcc115c2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list