Change in vdsm[master]: multipath: use a backup file instead of rotateFiles

ybronhei at redhat.com ybronhei at redhat.com
Sat Nov 8 08:16:55 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: multipath: use a backup file instead of rotateFiles
......................................................................


Patch Set 2:

(1 comment)

maybe use same way as mooli does with the other conf files (backup section instead of keeping the old conf file). please talk with him about it

http://gerrit.ovirt.org/#/c/34077/2/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:

Line 179:                 raise se.MultipathSetupError()
Line 180:             else:
Line 181:                 utils.persist(CONF_BACKUP)
Line 182: 
Line 183: 
vdsm/storage/multipath.py:184:5: E303 too many blank lines (2) - pep8 alerts
Line 184:     with tempfile.NamedTemporaryFile() as f:
Line 185:         f.write(MPATH_CONF_TEMPLATE % {'scsi_id_path': _scsi_id.cmd})
Line 186:         f.flush()
Line 187:         cmd = [constants.EXT_CP, f.name, MPATH_CONF]


-- 
To view, visit http://gerrit.ovirt.org/34077
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96a9251ebc852fcdf39239ba50f43dd2343b83a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list