Change in vdsm[master]: utils: change persistFile to persist
ybronhei at redhat.com
ybronhei at redhat.com
Sat Nov 8 08:01:41 UTC 2014
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: change persistFile to persist
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/34073/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-11-04 14:56:30 +0200
Line 6:
Line 7: utils: change persistFile to persist
Line 8:
Line 9: For compatibility reasons with pep8.
why? pep8 don't like persistFile ? sounds odd..
Line 10:
Line 11: Change-Id: I54cabe8976713169755933958d183eefbd4fac88
http://gerrit.ovirt.org/#/c/34073/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 55:
Line 56: try:
Line 57: # If failing to import old code, then try importing the legacy code
Line 58: from ovirtnode import ovirtfunctions
Line 59: persistFile = ovirtfunctions.ovirt_store_config
don't you need to change it also here?
Line 60: except ImportError:
Line 61: try:
Line 62: from ovirt.node.utils.fs import Config
Line 63: persist = Config().persist
--
To view, visit http://gerrit.ovirt.org/34073
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54cabe8976713169755933958d183eefbd4fac88
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list