Change in vdsm[master]: libvirtconnection: add function to create a new connection
danken at redhat.com
danken at redhat.com
Fri Nov 7 21:33:50 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: libvirtconnection: add function to create a new connection
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/34293/10/tests/libvirtconnectionTests.py
File tests/libvirtconnectionTests.py:
Line 104:
Line 105:
Line 106: class testLibvirtconnection(TestCaseBase):
Line 107: @MonkeyPatch(libvirtconnection, 'libvirt', LibvirtMock())
Line 108: @MonkeyPatch(constants, 'P_VDSM_LIBVIRT_PASSWD', '/dev/null')
monkey-patching the new _read_password() could be more elegant.
Line 109: def testCallSucceeded(self):
Line 110: """Positive test - libvirtMock does not raise any errors"""
Line 111: with run_libvirt_event_loop():
Line 112: LibvirtMock.virConnect.failGetLibVersion = False
--
To view, visit http://gerrit.ovirt.org/34293
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3481d56ee19afec14b36b98b412278148b26379e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list