Change in vdsm[master]: guestagent: Use new style class

danken at redhat.com danken at redhat.com
Fri Nov 7 21:20:00 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: guestagent: Use new style class
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/34624/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: guestagent: Use new style class
Line 8: 
Line 9: Using old style class is a trap for innocent developers. They do not
Line 10: support properties in a nasty way, and should be forbidden in vdsm code.
Can you add a reg-exp check against them?
Line 11: 
Line 12: Change-Id: I138ded6cb33d7927b2701606698aaf95ebf39742


-- 
To view, visit http://gerrit.ovirt.org/34624
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I138ded6cb33d7927b2701606698aaf95ebf39742
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list