Change in vdsm[master]: tests: make pyflakes happy with outOfProcess tests

danken at redhat.com danken at redhat.com
Fri Nov 7 14:50:21 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: make pyflakes happy with outOfProcess tests
......................................................................


tests: make pyflakes happy with outOfProcess tests

This patch fixes

python -c 'import pyflakes; print("pyflakes-%s" % pyflakes.__version__)'
pyflakes-0.8.1
find . -path './.git' -prune -type f -o \
	-name '*.py' -o -name '*.py.in'  | xargs
/home/fromani/.local/bin/pyflakes | \
	grep -w -v "\./vdsm/storage/lvm\.py.*: list comprehension
redefines 'lv' from line .*" | \
	while read LINE; do echo "$LINE"; false; done
./tests/outOfProcessTests.py:31: 'config' imported but unused

Change-Id: I5aa3ea1f1d26ff633a70317c10d456465c39ed74
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/34896
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/outOfProcessTests.py
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/34896
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5aa3ea1f1d26ff633a70317c10d456465c39ed74
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list