Change in vdsm[master]: External hypervisor VMs integration

fromani at redhat.com fromani at redhat.com
Fri Nov 7 07:50:40 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: External hypervisor VMs integration
......................................................................


Patch Set 18:

(1 comment)

http://gerrit.ovirt.org/#/c/33309/18/vdsm/v2v.py
File vdsm/v2v.py:

Line 30:               libvirt.VIR_DOMAIN_PAUSED: vmstatus.PAUSED,
Line 31:               libvirt.VIR_DOMAIN_SHUTDOWN: vmstatus.POWERING_DOWN,
Line 32:               libvirt.VIR_DOMAIN_SHUTOFF: vmstatus.DOWN,
Line 33:               libvirt.VIR_DOMAIN_CRASHED: 'Crashed',
Line 34:               libvirt.VIR_DOMAIN_PMSUSPENDED: 'PMSuspended'}
> ok, I will add the absent statuses to vmstatus
Nir's advice is good.
You can do something like we have for vdsm/virt/vmexitreason.py
Line 35: 
Line 36: 
Line 37: def getExternalVMList(uri, username, password):
Line 38:     conn = libvirtconnection.open_connection(uri=uri,


-- 
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list