Change in vdsm[master]: clientIF: strip unneeded logging
fromani at redhat.com
fromani at redhat.com
Thu Nov 6 12:30:22 UTC 2014
Francesco Romani has uploaded a new change for review.
Change subject: clientIF: strip unneeded logging
......................................................................
clientIF: strip unneeded logging
Everything we log inside clientIF.createVm is either
redundant or with little value.
Highlights
* if we need to debug vmContainerLock, there are better
and more comprehensive ways to do that
* no need to log error, it should be reported anyway.
So this patch strips all the logging from this method.
Change-Id: I0c5bf3c85d105885ae5eee5024ae2f0b9f69f4f7
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/clientIF.py
1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/34872/1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 440e5e7..9320b2e 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -377,21 +377,13 @@
def createVm(self, vmParams, vmRecover=False):
with self.vmContainerLock:
- self.log.info("vmContainerLock acquired by vm %s",
- vmParams['vmId'])
try:
if not vmRecover:
if vmParams['vmId'] in self.vmContainer:
- self.log.warning('vm %s already exists' %
- vmParams['vmId'])
return errCode['exist']
vm = Vm(self, vmParams, vmRecover)
self.vmContainer[vmParams['vmId']] = vm
- finally:
- container_len = len(self.vmContainer)
vm.run()
- self.log.debug("Total desktops after creation of %s is %d" %
- (vmParams['vmId'], container_len))
return {'status': doneCode, 'vmList': vm.status()}
@utils.traceback()
--
To view, visit http://gerrit.ovirt.org/34872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c5bf3c85d105885ae5eee5024ae2f0b9f69f4f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
More information about the vdsm-patches
mailing list