Change in vdsm[master]: vm: safe(r) Vm.conf update in creation thread

fromani at redhat.com fromani at redhat.com
Wed Nov 5 16:44:14 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: safe(r) Vm.conf update in creation thread
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/34813/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1395:         # For BC we need to save previous behaviour for old type parameters.
Line 1396:         # The new/old type parameter will be distinguished
Line 1397:         # by existence/absence of the 'devices' key
Line 1398:         with self._confLock:
Line 1399:             devConf = deepcopy(self.conf.get('devices'))
> If devices does not exists, there is no point in deep copying None.
Good point. Done.
Line 1400: 
Line 1401:         if devConf is None:
Line 1402:             devices[DISK_DEVICES] = self.getConfDrives()
Line 1403:             devices[NIC_DEVICES] = self.getConfNetworkInterfaces()


-- 
To view, visit http://gerrit.ovirt.org/34813
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9dee2aa01b2c231b99e02a879dcfbd7ecc7f70a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list