Change in vdsm[master]: domain_descriptor: Eliminate magic hash init value

fromani at redhat.com fromani at redhat.com
Wed Nov 5 13:30:20 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: domain_descriptor: Eliminate magic hash init value
......................................................................


Patch Set 1: Code-Review+1

Assuming the change you mentioned when we introduced GuestDiskMapping was reviewed (don't remember the details).

Anyway this is a (related but) different story, and this change looks OK and it is an improvement of the current code.

-- 
To view, visit http://gerrit.ovirt.org/34622
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36767eafbef3dbebef5a1d04417f18e0cc4898c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list