Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 4 16:25:48 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet
......................................................................


Patch Set 17:

(1 comment)

http://gerrit.ovirt.org/#/c/31529/17/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 186:                     key = "node.session." + key
Line 187:                     iscsiadm.node_update(iface.name, portalStr, target.iqn,
Line 188:                                          key, value, hideValue=True)
Line 189: 
Line 190:             if iface.netIfaceName:
> Or, better, I will probe the os device using netinfo.getRouteDeviceTo() and
Can you describe in more details why changing the rpfilter does not work when adding the second session? How can we reproduce this issue?
Line 191:                 supervdsm.getProxy().setRpFilter(iface.netIfaceName,
Line 192:                                                  _SYSCTL_RPFILTER_LOOSE)
Line 193: 
Line 194:             iscsiadm.node_login(iface.name, portalStr, target.iqn)


-- 
To view, visit http://gerrit.ovirt.org/31529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: jian wang <wjian84 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list