Change in vdsm[master]: hba: Parallel hba scanning

smizrahi at redhat.com smizrahi at redhat.com
Tue Nov 4 12:57:15 UTC 2014


Saggi Mizrahi has posted comments on this change.

Change subject: hba: Parallel hba scanning
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

As I've already discussed. You can't have that be done in multiple threads. It's needlessly expensive and can get VDSM stuck in D state.

http://gerrit.ovirt.org/#/c/34407/2/vdsm/storage/hba.py
File vdsm/storage/hba.py:

Line 63: 
Line 64:     cond = threading.Condition(threading.Lock())
Line 65:     scanning = [0]
Line 66: 
Line 67:     @utils.traceback(on=log.name)
Don't use utils.traceback it's going away soon.
Line 68:     def scanner(path):
Line 69:         try:
Line 70:             log.debug("Scanning %s", path)
Line 71:             fd = os.open(path, os.O_WRONLY)


-- 
To view, visit http://gerrit.ovirt.org/34407
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcd29551314a55bff2d2cc89f02f5c562f5d016
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list