Change in vdsm[master]: virt: move vm.GraphicsDevice -> vmdevices.Graphics

fromani at redhat.com fromani at redhat.com
Tue Nov 4 09:33:18 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: move vm.GraphicsDevice -> vmdevices.Graphics
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/34557/1/vdsm/virt/vmdevices.py
File vdsm/virt/vmdevices.py:

Line 362: 
Line 363:         return graphics
Line 364: 
Line 365: 
Line 366: def _getNetworkIp(network):
> From code point of view: making classes lean VS polluting the module - imho
I spoke with network team back in time when GraphicsDevice was introduced, apparently noone likes this poor little function, so there is no good in making it public.

For the sake of keeping classes lean, I'd like to keep it there.
Line 367:     try:
Line 368:         nets = netinfo.networks()
Line 369:         device = nets[network].get('iface', network)
Line 370:         ip, _, _, _ = netinfo.getIpInfo(device)


-- 
To view, visit http://gerrit.ovirt.org/34557
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8597ce1896b308204974b60f60a19cc52fca8e0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list