Change in vdsm[master]: hooks: Add a hook to configure IPv6 networking through custo...
osvoboda at redhat.com
osvoboda at redhat.com
Mon Nov 3 16:02:34 UTC 2014
Ondřej Svoboda has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom properties
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/34571/7/vdsm_hooks/ipv6/ipv6.py
File vdsm_hooks/ipv6/ipv6.py:
Line 36: def _process_network(attrs):
Line 37: for property_name in ('ipv6addr', 'ipv6gateway', 'ipv6autoconf', 'dhcpv6'):
Line 38: value = attrs['custom'].get(property_name)
Line 39: if value is not None:
Line 40: attrs[property_name] = value
> I don't think we can blindly copy ipv6autoconf and dhcpv6. It would be quit
hooking.tobool is actually utils.tobool, called in api.py:addNetwork a little later. The two booleans are subjected to
if dhcpv6 is not None:
dhcpv6 = utils.tobool(dhcpv6)
Line 41:
Line 42:
Line 43: if __name__ == '__main__':
Line 44: try:
--
To view, visit http://gerrit.ovirt.org/34571
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0e427b182a1742999eeb14e004209b511668ba2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list