Change in vdsm[master]: oop: Use a single instance of IOProcess per SD

danken at redhat.com danken at redhat.com
Mon Nov 3 15:45:22 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: oop: Use a single instance of IOProcess per SD
......................................................................


oop: Use a single instance of IOProcess per SD

Next step after switching from RFH to IOPROC is to
use a single IOProcess instance for each SD.

Currently only a single IOProcess instance is used
for all SDs.

To avoid load on the system by holding many unused
IOProcesses we will maintain dictionary:
KEY - domainID, VALUE - (timestamp, IOPROC)
When IOProc for domainID is used we will renew the
timestamp, or delete the item from dictionary

We will also maintain another dictionary:
KEY - domainID, VALUE - IOPROC weakref,
that will allow us to check if IOPROC obj is
still alive or needs to be recreated.

Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126206
Signed-off-by: Yeela Kaplan <ykaplan at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31501
Reviewed-by: Dima Kuznetsov <dkuznets at redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi at redhat.com>
---
M lib/vdsm/config.py.in
M vdsm/storage/outOfProcess.py
2 files changed, 51 insertions(+), 15 deletions(-)

Approvals:
  Yeela Kaplan: Verified
  Saggi Mizrahi: Looks good to me, approved
  Dima Kuznetsov: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/31501
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list