Change in vdsm[master]: vm: sync device update during creation of a vm

fromani at redhat.com fromani at redhat.com
Mon Nov 3 08:29:42 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: sync device update during creation of a vm
......................................................................


Patch Set 2:

We have quite some things mixed here.

Most likely (but not 100% sure) this hasn't happened before because
the XML marshaller (as Piotr found) used a different approach when iterating on python dictionaries, which kept things (quite) safe.
This changed in the 3.5 timeframe due mostly to json-rpc and live-merge. Both of those changes are not to blame, their interaction with the existing codebase however broke up things.

Simply to revert to the old method is feasible as short term solution, not as long term one.

The deeper problem is how badly Vm is intertwined. To fix this will cost time - first approach here: http://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:stable_vm_devices,n,z

As first-aid patch I'll see if it is possible to revert to the old path (items() vs iteritems()), but this solution is not very good either.

-- 
To view, visit http://gerrit.ovirt.org/34599
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I477551500ccc2297eb0c05d6562710bc420363a5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list