Change in vdsm[master]: netinfo, tool: Make the bonding defaults a proper Python file

osvoboda at redhat.com osvoboda at redhat.com
Mon Nov 3 00:36:54 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo, tool: Make the bonding defaults a proper Python file
......................................................................


Patch Set 4:

Toni, ls -Z for bonding_defaults.py shows system_u:object_r:lib_t:s0 (the same as for netinfo.py) both after installation and after running the tool manually (on EL6 and EL7). I see no clash here.

What is more important, the chicken-and-egg relation between netinfo.py and bonding_defaults.py. Whenever the latter is deleted or corrupted, not even the tool can be run to fix it (as it imports the file indirectly through netinfo.py).

This will become more important if we decide not to distribute bonding_defaults.py with VDSM. It would be necessary to wrap importing of the module in a try/catch block and warn that defaults are unavailable.

-- 
To view, visit http://gerrit.ovirt.org/33890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f62c0052e42ea23cc06e64fc9e158bf5dc4258
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list