Change in vdsm[master]: spec: remove redundant 'Requires(X): policycoreutils-python'.

mtayer at redhat.com mtayer at redhat.com
Sun Nov 2 13:27:43 UTC 2014


mooli tayer has uploaded a new change for review.

Change subject: spec: remove redundant 'Requires(X): policycoreutils-python'.
......................................................................

spec: remove redundant 'Requires(X): policycoreutils-python'.

Having an rpm as both 'Required' and 'Required(X) is redundant';
a 'Required' dependency is present for all stages.

There where two possible solutions here: remove the 'Required(X)'
or remove the 'Required' lines. I choose the first since an rpm
dependency for stage x, is a dependency for all stages before x.
This is done so that rpm will never ask to install a package when
trying to remove one[1]. This means that we practically need
policycoreutils-python for all stages (except postun).

See also:
[1] Context Marked Dependencies:
http://www.rpm.org/max-rpm-snapshot/s1-rpm-depend-manual-dependencies.html

[2] related vdsm patches:
8409, 10000

Change-Id: I293db914e41dde0020cf4da5b5f0b0723c3fac89
Signed-off-by: Mooli Tayer <mtayer at redhat.com>
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/34730/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 28e21ad..7922b48 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -261,9 +261,6 @@
 Requires(post): /bin/hostname
 %endif
 
-Requires(post): policycoreutils-python
-Requires(preun): policycoreutils-python
-
 %description
 The VDSM service is required by a Virtualization Manager to manage the
 Linux hosts. VDSM manages and monitors the host's storage, memory and


-- 
To view, visit http://gerrit.ovirt.org/34730
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I293db914e41dde0020cf4da5b5f0b0723c3fac89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>


More information about the vdsm-patches mailing list