Change in vdsm[ovirt-3.5]: volume: Log the correct error when creating a volume fails

ybronhei at redhat.com ybronhei at redhat.com
Sun Nov 2 07:03:37 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: volume: Log the correct error when creating a volume fails
......................................................................


volume: Log the correct error when creating a volume fails

When a volume creation failed because of CannotCreateLogicalVolume
exception, we used to lie and log "volume already exists". This log
confused and wasted many developers hours. Now we log the exception
value instead.

Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef
Bug-Url: https://bugzilla.redhat.com/1143830
Relates-To: https://bugzilla.redhat.com/1142710
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33301
Reviewed-by: Yoav Kleinberger <ykleinbe at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
(cherry picked from commit 3e17f9828576f16e4ef95f805c2e7ce27b63d812)
Reviewed-on: http://gerrit.ovirt.org/34639
Tested-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/storage/volume.py
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Allon Mureinik: Verified



-- 
To view, visit http://gerrit.ovirt.org/34639
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list