Change in vdsm[master]: setupNetworks: doesn't remove broken nw from runningConfig

danken at redhat.com danken at redhat.com
Sat Nov 1 22:16:28 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: setupNetworks: doesn't remove broken nw from runningConfig
......................................................................


setupNetworks: doesn't remove broken nw from runningConfig

This patch extends http://gerrit.ovirt.org/#/c/22354/:
network/api.py:setupNetworks() removes broken networks - if network
is not listed in netinfo, but it's in libvirt, _delBrokenNetwork()
is called.

The problem is that when the network doesn't have an existing device,
we only remove it from libvirt and leave it in RunningConfig.

TODO: this problem occurs on 3.4 with libvirt 1.2.9

Now _delBrokenNetwork() remove broken network from runningConfig.

NOTE: This patch doesn't handle the case, when the network is only in
RunningConfig, not in libvirt, not in netinfo. This should be solved in
a separate patch.

Change-Id: I0c507626705d7ead84db2f3aa15e4032f9558d12
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33995
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/network/api.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33995
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c507626705d7ead84db2f3aa15e4032f9558d12
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list