Change in vdsm[master]: core: removal of unneeded callback passing

danken at redhat.com danken at redhat.com
Fri May 30 12:09:54 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: core: removal of unneeded callback passing
......................................................................


core: removal of unneeded callback passing

The callback can be executed from sp.py after completing the operation,
eliminating the need to pass it to imageSharing.

Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9
Signed-off-by: Liron Aravot <laravot at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/26760
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Yoav Kleinberger <ykleinbe at redhat.com>
Reviewed-by: Xavi Francisco <xfrancis at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/storage/image.py
M vdsm/storage/sp.py
2 files changed, 6 insertions(+), 11 deletions(-)

Approvals:
  Xavi Francisco: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Federico Simoncelli: Looks good to me, approved
  Yoav Kleinberger: Looks good to me, but someone else must approve
  Liron Ar: Verified



-- 
To view, visit http://gerrit.ovirt.org/26760
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list