Change in vdsm[master]: virt: stats: move the guest stats in a method

vfeenstr at redhat.com vfeenstr at redhat.com
Fri May 30 07:22:15 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: virt: stats: move the guest stats in a method
......................................................................


Patch Set 9:

That means additionally of course. The easiest way to have this, is to install the guest agent on the guest vm and you can start and stop it there. And rerun your tests by restarting vdsm in the meantime (which would flush all data). If the guest agent service is not running, after a restart of vdsm it's like it wouldn't be there.
When it is running it, obviously is.
But it's important to test both scenarios since this code has conditionals in it which works with the data from the guest agent ;)

-- 
To view, visit http://gerrit.ovirt.org/26554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83adb6ddc28777c50190229e5da728a3bdb3b24e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list