Change in vdsm[master]: profile: Test profile decorator format

nsoffer at redhat.com nsoffer at redhat.com
Thu May 29 21:52:17 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: profile: Test profile decorator format
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/27786/2/tests/profileTests.py
File tests/profileTests.py:

Line 142:     def test_ystat_format(self):
Line 143:         requires_yappi()
Line 144:         self.ystat_format()
Line 145:         stats = yappi.YFuncStats()
Line 146:         stats.add(FILENAME)
> Good point.
Fixed in next patch using new assertNotRaises: http://gerrit.ovirt.org/28177
Line 147: 
Line 148:     @profile.profile(FILENAME)
Line 149:     def profiled_function(self):
Line 150:         self.assertTrue(profile.is_running())


-- 
To view, visit http://gerrit.ovirt.org/27786
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list