Change in vdsm[master]: tests: Add assertNotRaises assertion

nsoffer at redhat.com nsoffer at redhat.com
Thu May 29 21:51:40 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tests: Add assertNotRaises assertion
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28177/1//COMMIT_MSG
Commit Message:

Line 30: 
Line 31:     with self.assertNotRaises(Error):
Line 32:         that_func('foo')
Line 33:         other_func('bar')
Line 34: 
Examples without specifying an exception will be more useful:

    self.assertNotRaises(func, "foo")

    with self.assertNotRaises():
        func("foo")
Line 35: The test will fail Error or subclass of Error is raised, but will pass
Line 36: if it raises unrelated error.
Line 37: 
Line 38: Change-Id: I33c96ca855753a75ffe2f82bdecab2e1612da08a


-- 
To view, visit http://gerrit.ovirt.org/28177
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33c96ca855753a75ffe2f82bdecab2e1612da08a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list