Change in vdsm[master]: Setting enum for isconfigured return value and change overri...

ybronhei at redhat.com ybronhei at redhat.com
Thu May 29 12:24:38 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Setting enum for isconfigured return value and change override semantics
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/28007/4/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 183:         gid = pwd.getpwnam(SANLOCK_USER).pw_gid
Line 184:         groups.append(grp.getgrgid(gid).gr_name)
Line 185:         if all(group in self.SANLOCK_GROUPS for group in groups):
Line 186:             configured = NOT_SURE
Line 187: 
> by bad...
i didn't put it in if NOT_SURE??! oops
Line 188:         try:
Line 189:             with open("/var/run/sanlock/sanlock.pid", "r") as f:
Line 190:                 sanlock_pid = f.readline().strip()
Line 191:             with open(os.path.join('/proc', sanlock_pid, 'status'),


-- 
To view, visit http://gerrit.ovirt.org/28007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list