Change in vdsm[master]: Setting enum for isconfigured return value and change overri...

Alon Bar-Lev alonbl at redhat.com
Thu May 29 11:35:21 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: Setting enum for isconfigured return value and change override semantics
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/28007/3/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 209:                           if SANLOCK_USER in g.gr_mem]
Line 210:                 gid = pwd.getpwnam(SANLOCK_USER).pw_gid
Line 211:                 groups.append(grp.getgrgid(gid).gr_name)
Line 212:                 if all(group in self.SANLOCK_GROUPS for group in groups):
Line 213:                     configured = CONFIGURED
> agree, although we still have edge case where user can run it properly and 
so we return not configured... all will work... and service will be restarted after new settings. which is kinda ok...

if you want to really solve this you can return dict with runtime enum and persistent enum... and only if runtime is not CONFIGURED restart... :))))
Line 214:             else:
Line 215:                 raise
Line 216: 
Line 217:         if configured == NOT_CONFIGURED:


-- 
To view, visit http://gerrit.ovirt.org/28007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list