Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags

dkuznets at redhat.com dkuznets at redhat.com
Thu May 29 10:42:30 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: vdsm-tool: Add logging and verbosity flags
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/27481/8/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:

Line 146: 
Line 147:     if verbose:
Line 148:         level = logging.DEBUG
Line 149:     else:
Line 150:         level = logging.WARNING
> the traditional thing for verbosity is:
But getopt doesn't support this :(
Line 151: 
Line 152:     if log_file is not None:
Line 153:         handler = logging.FileHandler(log_file, mode=(append and 'a' or 'w'))
Line 154:     else:


-- 
To view, visit http://gerrit.ovirt.org/27481
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia495743f6e869f65843404e4d4c25c146ff14b43
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list