Change in vdsm[master]: vdsClient: alternative ways to provide password

Alon Bar-Lev alonbl at redhat.com
Thu May 29 10:37:22 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: vdsClient: alternative ways to provide password
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.ovirt.org/#/c/24733/15/client/vdsClient.py
File client/vdsClient.py:

Line 418:         for arg in args[3:]:
Line 419:             if arg in ['disconnect', 'keep', 'fail']:
Line 420:                 connAct = arg
Line 421:             elif arg.startswith('param='):
Line 422:                 params = self._parseDriveSpec(args[4])
> I avoided changing the original params, but I think there is no reason not 
so it will be better not to introduce more parameters, and manage the key=value,... syntax which is more flexible.
Line 423:             else:
Line 424:                 extra_args = parseArgs(arg)
Line 425:                 if 'auth' in extra_args:
Line 426:                     auth_password = getPassword(extra_args['auth'])


-- 
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list