Change in vdsm[master]: BindingXmlRPC - do_PUT to return created task id in header

nsoffer at redhat.com nsoffer at redhat.com
Wed May 28 20:44:08 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: BindingXmlRPC - do_PUT to return created task id in header
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

The API implemented here does not agree with the one implemented in http://gerrit.ovirt.org/26741

http://gerrit.ovirt.org/#/c/27997/5/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:

Line 178:                         self.send_header(self.HEADER_TASK_ID, response['uuid'])
Line 179:                         self.end_headers()
Line 180:                     else:
Line 181:                         self.send_response(httplib.INTERNAL_SERVER_ERROR)
Line 182:                         json_response = json.dumps(response)
So we return the task id twice? once in a header and once in the json response?
Line 183:                         self.send_header(self.HEADER_CONTENT_TYPE,
Line 184:                                          'application/json')
Line 185:                         self.send_header(self.HEADER_CONTENT_LENGTH,
Line 186:                                          len(json_response))


-- 
To view, visit http://gerrit.ovirt.org/27997
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25b13f44a65cb2c794c458b03ba361bf0af92120
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list