Change in vdsm[master]: virt: Ensure not to handle no longer tacked fds in epoll

danken at redhat.com danken at redhat.com
Wed May 28 18:10:38 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: virt: Ensure not to handle no longer tacked fds in epoll
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/28179/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-05-28 14:53:28 +0200
Line 6: 
Line 7: virt: Ensure not to handle no longer tacked fds in epoll
Line 8: 
Line 9: In some cases it is possible that events from epoll are received before the
> Could you please provide one example of such cases, to better understand th
Please do - I'd love to understand the race that caused fd to disappear from _channels before an event related to it has been handled. I'd like to convince myself that no other instance of this condition is lurking.
Line 10: socket is closed. This patch ensures that we're still tracking the fd for
Line 11: which we're receiving the event.
Line 12: 
Line 13: Change-Id: Idde0f89d2859107dd1bb697d1753709137335677


Line 7: virt: Ensure not to handle no longer tacked fds in epoll
Line 8: 
Line 9: In some cases it is possible that events from epoll are received before the
Line 10: socket is closed. This patch ensures that we're still tracking the fd for
Line 11: which we're receiving the event.
I think that a better wording of what this patch does is: this patch ignore events that belong to channels that are no longer tracked.
Line 12: 
Line 13: Change-Id: Idde0f89d2859107dd1bb697d1753709137335677
Line 14: Bug-Url: https://bugzilla.redhat.com/1102072


-- 
To view, visit http://gerrit.ovirt.org/28179
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde0f89d2859107dd1bb697d1753709137335677
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list