Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

dkuznets at redhat.com dkuznets at redhat.com
Wed May 28 15:11:04 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: vdsm-tool: Change upgrade mechanism
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/27193/11/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:

Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
Line 21: VDSM_TOOL="@BINDIR@/vdsm-tool"
Line 22: UPGRADE_LOGGING_PARAMS="--verbose --append --logfile=@VDSMLOGDIR@/upgrade.log"
> will this not break since these have not been defined yet?
you're right, it won't fly with getopt, but order of the patches cannot be changed either (explained in comments).
I'll move this to a later commit (separate or the one that adds the flags)
Line 23: prog=vdsm
Line 24: 
Line 25: #### pre-start tasks ####
Line 26: task_configure_coredump() {


-- 
To view, visit http://gerrit.ovirt.org/27193
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1d28570dedfeff9fe60624b1db72d8cadf136a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list